Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old .golangci test file, remove lint exlusion #2831

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 14, 2025

No description provided.

@iwahbe iwahbe requested a review from a team January 14, 2025 12:28
@iwahbe iwahbe self-assigned this Jan 14, 2025
@iwahbe iwahbe force-pushed the iwahbe/cleanup-test-lints branch from 54ce2dc to 5d97611 Compare January 14, 2025 12:51
@iwahbe iwahbe force-pushed the iwahbe/cleanup-test-lints branch from 5d97611 to e887198 Compare January 14, 2025 13:37
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.69%. Comparing base (f68bff0) to head (e887198).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2831   +/-   ##
=======================================
  Coverage   68.69%   68.69%           
=======================================
  Files         325      325           
  Lines       41621    41621           
=======================================
  Hits        28593    28593           
  Misses      11422    11422           
  Partials     1606     1606           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iwahbe iwahbe merged commit 1bec71d into master Jan 14, 2025
17 checks passed
@iwahbe iwahbe deleted the iwahbe/cleanup-test-lints branch January 14, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants