Full fidelity SDKv2 crosstest.Create equality
#2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2840 +/- ##
==========================================
- Coverage 67.49% 67.48% -0.01%
==========================================
Files 325 325
Lines 41621 41633 +12
==========================================
+ Hits 28093 28097 +4
- Misses 11951 11957 +6
- Partials 1577 1579 +2 ☔ View full report in Codecov by Sentry. |
iwahbe
force-pushed
the
iwahbe/full-fidelity-create-cross-tests
branch
from
b38a215 to
34c02db
Compare
Supply `tfprotov5.ApplyResourceChangeRequest.ProviderMeta` when we call `ApplyResourceChange` in SDKv2 providers. This gets us to a byte for byte identical result for SDKv2 `crosstest.Create`. This allows us to simplify (and strengthen) the comparison to general equality. Related to #2521
iwahbe
force-pushed
the
iwahbe/full-fidelity-create-cross-tests
branch
from
34c02db to
b4300c5
Compare
iwahbe
commented
Jan 17, 2025
| // `assert`'s default `reflect.DeepEqual` because cmp treats identical | ||
| // function pointers as equal, but `reflect.DeepEqual` does not. | ||
| opts := []cmp.Option{ | ||
| cmp.Exporter(func(reflect.Type) bool { return true }), |
There was a problem hiding this comment.
This has cmp compare all un-exported fields.
Comment on lines
+130
to
+132
| cmp.Comparer(func(x, y schema.SchemaStateFunc) bool { | ||
| return reflect.ValueOf(x).Pointer() == reflect.ValueOf(y).Pointer() | ||
| }), |
There was a problem hiding this comment.
This implements pointer equality for schema.SchemaStateFunc.
Comment on lines
+641
to
+652
| var providerMetaVal []byte | ||
| if providerMeta != nil { | ||
| providerMetaVal, err = msgpack.Marshal(*providerMeta, providerMeta.Type()) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } else { | ||
| providerMetaVal, err = msgpack.Marshal(cty.NullVal(cty.EmptyObject), cty.EmptyObject) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } |
There was a problem hiding this comment.
The previous compare function wasn't catching this, but the new comparison does. This now more accurately imitates TF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supply
tfprotov5.ApplyResourceChangeRequest.ProviderMetawhen we callApplyResourceChangein SDKv2 providers. This gets us to a byte for byte identical result for SDKv2crosstest.Create. This allows us to simplify (and strengthen) the comparison to general equality.Related to #2521