(PDB-4269) PQL: support 64-bit integers (matching puppet)

Match the current "practical limit" on integers. Previously PQL integers were 32-bit: https://puppet.com/docs/puppet/6.17/lang_data_number.html#lang_data_number_integer_type
puppetlabs · Aug 5, 2020 · 189bb7b · 189bb7b
1 parent e3abb42
commit 189bb7b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/puppetlabs/puppetdb/pql/transform.clj b/src/puppetlabs/puppetdb/pql/transform.clj
@@ -91,10 +91,12 @@
     :false false))
 
 (defn transform-integer
+  ;; 64-bit
+  ;; https://puppet.com/docs/puppet/5.3/lang_data_number.html#the-integer-data-type
   ([int]
-   (Integer. int))
+   (Long. int))
   ([neg int]
-   (- (Integer. int))))
+   (Long. (str neg int))))
 
 (defn transform-real
   [& args]

diff --git a/test/puppetlabs/puppetdb/pql_test.clj b/test/puppetlabs/puppetdb/pql_test.clj
@@ -24,6 +24,9 @@
     ["from" "nodes"
      ["and" ["=" "a" 1] ["=" "b" 2]]]
 
+    (format "nodes { a = %d and b = %d }" Long/MAX_VALUE Long/MIN_VALUE)
+    ["from" "nodes"
+     ["and" ["=" "a" Long/MAX_VALUE] ["=" "b" Long/MIN_VALUE]]]
 
     "fact_contents {path = [\"foo\",\"bar\"]}"
     ["from" "fact_contents"