-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pura Interview Challenge #24
Open
patch-benjamin
wants to merge
34
commits into
puradev:main
Choose a base branch
from
patch-benjamin:updateProject
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use $(inherited) so targets all use main projects setting.
Prep for HistoryView
patch-benjamin
commented
Sep 30, 2024
} | ||
|
||
#Preview { | ||
LoadingImage() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-09-29.at.23.56.56.mp4
OVERVIEW:
I made several significant changes in this code challenge. I went over the 2-4 hour time box, but I'll mark where 4 hours would have been for your reference. The commit history should be pretty easy to glance over (though is not super descriptive).
The app approach I went with for my changes was to make a kind of Frayer Model app that shows you the definition, images, synonyms, and lets you write notes on your take aways.
STEPS TAKEN:
I didn't get to spend as much time on this as I would have liked and I chased the features rather than polishing the app as much as I would have if I were to make an actual PR for this.
TODOS:
Some things I would like to improve:
searchable
and manually put in a TextField at the top cause searchable suuuucks.Anyway, you get the idea - lots of things I'd love to dive into but I didn't want to go super crazy over time so I called it here.