Fix intDiv for bigints by not using floats #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested that this agrees with behavior of the JS Prelude for negative integers
unfortunately both purerl and purescript-backend-erl will optimize to regular Erlang
div
(in different scenarios, since backend-erl does optimizations), so the correctness of this FFI implementation ends up not mattering much(how I found the bigint bug was by disabling the optimization)
Proof that this works for bigints: