WithLifecycle parameters was generating non-optional types. fixed tha…

…t by explicitly typing WithLifecycle
purifyjs · Dec 20, 2024 · 26243bb · 26243bb
1 parent 4a642f3
commit 26243bb
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/tags.ts b/lib/tags.ts
@@ -280,9 +280,14 @@ export type WithLifecycle<T extends HTMLElement> = T & {
     effect(callback: Lifecycle.OnConnected<T>): Lifecycle.OffConnected
 }
 
-export let WithLifecycle = <T extends keyof HTMLElementTagNameMap>(
+export let WithLifecycle: <T extends keyof HTMLElementTagNameMap>(
+    tagName: T,
+    newTagName?: `${string}-${string}`
+) => { new (): WithLifecycle<HTMLElementTagNameMap[T]> } = <
+    T extends keyof HTMLElementTagNameMap
+>(
     tagname: T,
-    newTagName = `pure-${tagname}` as `${string}-${string}`,
+    newTagName = `pure-${tagname}`,
     constructor = custom.get(newTagName) as new () => WithLifecycle<
         HTMLElementTagNameMap[T]
     >