double connected call issue fixed

purifyjs · Dec 26, 2024 · ddbb5b2 · ddbb5b2
1 parent 9966a12
commit ddbb5b2
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/tags.ts b/lib/tags.ts
@@ -284,9 +284,10 @@ export let WithLifecycle = <Base extends new (...params: any[]) => HTMLElement>(
 
         effect(callback: Lifecycle.OnConnected<this>): Lifecycle.OffConnected {
             this.#connectedCallbacks.add(callback)
-            if (this.isConnected) {
+            // Commented because causes issues when custom element defined while also being already connected
+            /* if (this.isConnected) {
                 this.#disconnectedCallbacks.push(callback(this))
-            }
+            } */
 
             return () => {
                 this.#connectedCallbacks.delete(callback)