turn on no confusing non null assertions rule on

puzzle · Dec 20, 2024 · 22c7da3 · 22c7da3
1 parent d90865a
commit 22c7da3
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/frontend/eslint.config.mjs b/frontend/eslint.config.mjs
@@ -83,8 +83,8 @@ export default tsEslint.config(
       '@angular-eslint/component-class-suffix': 'error',
       '@typescript-eslint/no-non-null-asserted-optional-chain': 'error',
       '@typescript-eslint/no-non-null-assertion': 'error',
-      '@stylistic/no-extra-parens': 'off',
-      '@typescript-eslint/no-confusing-non-null-assertion': 'off',
+      '@stylistic/no-extra-parens': 'error',
+      '@typescript-eslint/no-confusing-non-null-assertion': 'error',
       //Delete these rules after fixing all the issues and enabling the actual rules
       '@stylistic/quotes': 'off',
       '@stylistic/function-call-argument-newline': 'off',

diff --git a/frontend/src/app/shared/common.ts b/frontend/src/app/shared/common.ts
@@ -15,7 +15,9 @@ export function getValueFromQuery (query: any, fallback?: number): number[] {
   const values = Array.from([query])
     .flat()
     .filter((e) => e !== "")
-    .map((e) => (typeof e == 'string' ? e.split(',') : e))
+    .map((e) => {
+      return typeof e == 'string' ? e.split(',') : e;
+    })
     .flat()
     .map((id: any) => Number(id))
     .filter((id: number) => Number.isInteger(id));

diff --git a/frontend/src/app/shared/custom/scoring/scoring.component.spec.ts b/frontend/src/app/shared/custom/scoring/scoring.component.spec.ts
@@ -172,8 +172,8 @@ describe("ScoringComponent",
             component.commitPercent = 0;
             component.failPercent = 0;
 
-            // Set zone
-            (component.keyResult.lastCheckIn as CheckInOrdinalMin)!.zone! = object.zoneValue;
+            // Set zonen
+            (component.keyResult.lastCheckIn as CheckInOrdinalMin).zone = object.zoneValue;
             component.calculatePercentageOrdinal();
 
             // Verify if percentage was set correctly

diff --git a/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.ts b/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.ts
@@ -198,7 +198,7 @@ export class ObjectiveFormComponent implements OnInit, OnDestroy {
         {
           objective: objectiveDTO,
           keyResults: this.keyResults
-            .filter((keyResult, index) => (this.objectiveForm.value.keyResults ? this.objectiveForm.value.keyResults[index] : false))
+            .filter((keyResult, index) => this.objectiveForm.value.keyResults?.[index] ?? false)
             .map((result) => ({
               ...result,
               id: undefined

diff --git a/frontend/src/app/team-management/search-team-management/search-team-management.component.ts b/frontend/src/app/team-management/search-team-management/search-team-management.component.ts
@@ -59,7 +59,7 @@ export class SearchTeamManagementComponent {
       .pipe(
         takeUntilDestroyed(),
         debounceTime(200),
-        map((v) => (v ? v.trim() : '')),
+        map((v) => (v ?? "").trim()),
         distinctUntilChanged()
       )
       .subscribe((searchValue) => {