Try to fix section tags on overview and detail views

puzzle · Oct 30, 2024 · 6748b0e · 6748b0e
1 parent e649a76
commit 6748b0e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/frontend/src/app/components/keyresult-detail/keyresult-detail.component.html b/frontend/src/app/components/keyresult-detail/keyresult-detail.component.html
@@ -31,7 +31,7 @@ <h4 *ngIf="keyResult?.objective?.quarter as quarter">{{ quarter.label }}</h4>
           </span>
         </section>
 
-        <div class="d-flex gap-4 flex-row mt-2">
+        <section class="d-flex gap-4 flex-row mt-2">
           <ng-container *ngIf="keyResult.keyResultType == 'metric' && castToMetric(keyResult) as keyResultMetric">
             <div class="d-flex justify-content-start w-100 metric-label-div">
               <h5 class="keyResult-detail-attribute-show rounded-5 p-2 d-flex justify-content-center metric-col">
@@ -79,7 +79,7 @@ <h5 class="ordinal-zone-title">Stretch</h5>
               </div>
             </div>
           </ng-container>
-        </div>
+        </section>
 
         <section *ngIf="keyResult.lastCheckIn as checkIn" class="mt-4">
           <h3 class="sub-title-keyresult-detail fw-bold mb-1">

diff --git a/frontend/src/app/components/objective-detail/objective-detail.component.html b/frontend/src/app/components/objective-detail/objective-detail.component.html
@@ -1,7 +1,7 @@
 <div class="w-100" [cdkTrapFocus]="true" [cdkTrapFocusAutoCapture]="true">
   <ng-container *ngIf="(objective$ | async)?.id && (objective$ | async) as objective; else spinner">
     <div *ngIf="objective" class="d-flex flex-column">
-      <div class="w-100 d-flex justify-content-between align-items-center mb-3">
+      <section class="w-100 d-flex justify-content-between align-items-center mb-3">
         <h2 class="title">{{ objective.title }}</h2>
         <button
           class="d-flex align-items-center justify-content-center"
@@ -11,7 +11,7 @@ <h2 class="title">{{ objective.title }}</h2>
         >
           <mat-icon class="d-flex justify-content-center align-items-center">close</mat-icon>
         </button>
-      </div>
+      </section>
 
       <section class="me-3">
         <h3 class="sub-title-objective fw-bold mb-1">Beschrieb</h3>

diff --git a/frontend/src/app/components/objective/objective.component.html b/frontend/src/app/components/objective/objective.component.html
@@ -33,7 +33,7 @@ <h2 class="title fit-content">{{ objective.title }}</h2>
       </button>
     </section>
 
-    <div class="d-flex px-3 gap-3 flex-column">
+    <section class="d-flex px-3 gap-3 flex-column">
       <app-keyresult
         *ngFor="let keyResult of objective.keyResults; trackBy: trackByFn"
         class="border-0 p-0"
@@ -42,7 +42,7 @@ <h2 class="title fit-content">{{ objective.title }}</h2>
         [keyResult]="keyResult"
         [attr.data-testId]="'keyresult'"
       ></app-keyresult>
-    </div>
+    </section>
 
     <section class="p-0 py-2 m-0">
       <button