Add close dialog method, remove unused method from objective form pag…

…e and start implementing keyresult form page

frontend/cypress/support/baseFormPage.ts

@@ -13,6 +13,10 @@ export default abstract class BaseFormPage {
     cy.getByTestId('cancel').click();
   }
 
+  close() {
+    cy.getByTestId('close-dialog').click();
+  }
+
   protected fillInput(testId: string, value: string) {
     cy.getByTestId(testId).clear();
     cy.getByTestId(testId).type(value);

frontend/cypress/support/keyresultFormPage.ts

@@ -0,0 +1,35 @@
+import BaseFormPage from './baseFormPage';
+import {Unit} from "../../src/app/shared/types/enums/Unit";
+
+export default class CyKeyResultFormPage extends BaseFormPage {
+  init() {
+    cy.get('app-objective-form').should('exist');
+  }
+
+  fillKeyresultTitle(title: string) {
+    this.fillInput('titleInput', title);
+    return this;
+  }
+
+  fillKeyresultDescription(description: string) {
+    this.fillInput('descriptionInput', description);
+    return this;
+  }
+
+  withMetricValues(unit: Unit, baseline: string, stretchGoal: string) {
+    cy.getByTestId('unit').select(unit);
+    this.fillInput('baseline', baseline);
+    this.fillInput('stretchGoal', stretchGoal);
+  }
+
+  withOrdinalValues(commitZone: string, targetZone: string, stretchGoal: string) {
+    cy.getByTestId('ordinalTab').click();
+    this.fillInput('commitZone', commitZone);
+    this.fillInput('targetZone', targetZone);
+    this.fillInput('stretchZone', stretchGoal);
+  }
+
+  saveAndNew() {
+    cy.getByTestId('saveAndNew').click();
+  }
+}

frontend/cypress/support/objectiveFormPage.ts

@@ -5,10 +5,6 @@ export default class CyObjectiveFormPage extends BaseFormPage {
     cy.get('app-objective-form').should('exist');
   }
 
-  visit() {
-    cy.visit('/objective-form');
-  }
-
   fillObjectiveTitle(title: string) {
     this.fillInput('title', title);
     return this;

frontend/src/app/shared/custom/dialog-template-core/dialog-template-core.component.html

@@ -3,7 +3,7 @@
     <div class="row">
       <h2 class="col d-flex justify-content-between align-items-center my-2">
         {{ title }}
-        <button mat-dialog-close mat-icon-button>
+        <button mat-dialog-close mat-icon-button [attr.data-testId]="'close-dialog'">
           <mat-icon class="text-secondary">close</mat-icon>
         </button>
       </h2>