Remove not necessary tags, replace missplaced ones and so on

puzzle · Oct 23, 2024 · 8caca4c · 8caca4c
1 parent efd7c17
commit 8caca4c
Show file tree

Hide file tree

Showing 9 changed files with 22 additions and 30 deletions.
diff --git a/frontend/src/app/components/keyresult-detail/keyresult-detail.component.html b/frontend/src/app/components/keyresult-detail/keyresult-detail.component.html
@@ -82,9 +82,9 @@ <h3 class="title">{{ keyResult.title }}</h3>
         </div>
 
         <section *ngIf="keyResult.lastCheckIn as checkIn" class="mt-4">
-          <h2 class="sub-title-keyresult-detail fw-bold mb-1">
+          <h4 class="sub-title-keyresult-detail fw-bold mb-1">
             Letztes Check-in ({{ checkIn.createdOn | date: DATE_FORMAT }})
-          </h2>
+          </h4>
           <p class="linebreak" *ngIf="checkIn.changeInfo">{{ checkIn.changeInfo }}</p>
           <span class="d-flex justify-content-start">
             <button

diff --git a/frontend/src/app/components/objective-filter/objective-filter.component.html b/frontend/src/app/components/objective-filter/objective-filter.component.html
@@ -1,4 +1,4 @@
-<form class="d-flex search-form" (ngSubmit)="this.refresh.next()">
+<form class="d-flex search-form" (ngSubmit)="refresh.next()">
   <mat-form-field
     id="objective-form-field"
     class="bg-white header-form-field"
@@ -11,7 +11,7 @@
       [type]="'text'"
       [placeholder]="'Nach Objectives suchen'"
       [(ngModel)]="query"
-      (input)="this.refresh.next()"
+      (input)="refresh.next()"
       [ngModelOptions]="{ standalone: true }"
       [attr.data-testId]="'objectiveSearch'"
     />
@@ -20,6 +20,7 @@
   <button
     class="bg-pz-dark-blue d-flex justify-content-start align-items-center icon-button px-3 focus-outline"
     type="submit"
+    aria-label="Search Objectives"
   >
     <img src="../assets/icons/search-icon.svg" alt="search icon" class="text-white search-scale" />
   </button>

diff --git a/frontend/src/app/components/objective-filter/objective-filter.component.scss b/frontend/src/app/components/objective-filter/objective-filter.component.scss
@@ -1,3 +1,8 @@
 #objective-form-field {
   width: 300px;
 }
+
+.search-scale {
+  transform: scale(1.2);
+}
+
diff --git a/frontend/src/app/components/overview/overview.component.html b/frontend/src/app/components/overview/overview.component.html
@@ -1,5 +1,5 @@
 <app-application-banner id="bannerComponent"></app-application-banner>
-<div id="overview" class="overviewContainer px-sm-4" [ngStyle]="{ 'padding-top.px': overviewPadding | async }">
+<div id="overview" class="overview-container px-sm-4" [ngStyle]="{ 'padding-top.px': overviewPadding | async }">
   <app-team
     *ngFor="let overviewEntity of overviewEntities$ | async; trackBy: trackByFn"
     [overviewEntity]="overviewEntity"

diff --git a/frontend/src/app/components/overview/overview.component.scss b/frontend/src/app/components/overview/overview.component.scss
@@ -1,6 +1,6 @@
 @import "../style/variables";
 
-.overviewContainer {
+.overview-container {
   overflow-x: hidden;
   background-color: $overview-bg;
   transition: 0.5s;

diff --git a/frontend/src/app/components/team/team.component.html b/frontend/src/app/components/team/team.component.html
@@ -1,10 +1,10 @@
 <div *ngIf="overviewEntity as OVEntity" class="bg-grey justify-content-between pt-3">
   <section class="team-header">
-    <span class="d-flex align-items-center gap-2">
+    <div class="d-flex align-items-center gap-2">
       <div class="d-flex align-items-center flex-row">
         <h1 class="team-title">{{ OVEntity.team.name }}</h1>
       </div>
-    </span>
+    </div>
     <button
       (click)="createObjective()"
       *ngIf="OVEntity.writeable"
@@ -22,7 +22,7 @@ <h1 class="team-title">{{ OVEntity.team.name }}</h1>
 
   <div
     class="d-flex row flex-wrap justify-content-sm-between justify-content-md-start pb-2"
-    data-testid="objective-container"
+    [attr.data-testId]="'objective-container'"
   >
     <app-objective-column
       *ngFor="let objective of OVEntity.objectives; trackBy: trackByObjectiveId"

diff --git a/frontend/src/app/objective-filter/objective-filter.component.scss b/frontend/src/app/objective-filter/objective-filter.component.scss
diff --git a/frontend/src/app/shared/custom/dialog-header/dialog-header.component.html b/frontend/src/app/shared/custom/dialog-header/dialog-header.component.html
@@ -1,6 +1,6 @@
 <div class="d-flex justify-content-between align-items-center position-relative dialog-header mt-1">
   <h3 class="title w-75">
-    <span>{{ dialogTitle }}</span>
+    {{ dialogTitle }}
   </h3>
   <div class="d-flex align-items-center w-25 p-0 m-0">
     <button

diff --git a/frontend/src/app/shared/custom/scoring/scoring.component.html b/frontend/src/app/shared/custom/scoring/scoring.component.html
@@ -1,17 +1,15 @@
 <div class="d-flex flex-column">
   <div class="scoring-container d-flex flex-row">
     <div class="flex-fill">
-      <div>
-        <span class="okr-score-label">
+        <div class="okr-score-label">
           <span class="text-center text-small">Fail</span>
-        </span>
-        <span class="okr-score-label okr-score-commit">
+        </div>
+        <div class="okr-score-label okr-score-commit">
           <span class="text-center text-small">Commit</span>
-        </span>
-        <span class="okr-score-label">
+        </div>
+        <div class="okr-score-label">
           <span class="text-center text-small">Target</span>
-        </span>
-      </div>
+        </div>
       <div
         [ngStyle]="{ display: stretched ? 'none' : 'flex' }"
         [attr.data-testId]="'normal-scoring'"