fix duplicate keyresult tests

puzzle · Jan 14, 2025 · be380b4 · be380b4
1 parent dc85487
commit be380b4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/backend/src/main/java/ch/puzzle/okr/service/business/ObjectiveBusinessService.java b/backend/src/main/java/ch/puzzle/okr/service/business/ObjectiveBusinessService.java
@@ -177,7 +177,7 @@ public KeyResult makeCopyOfKeyResultOrdinal(KeyResult keyResult, Objective dupli
 
     public List<Action> duplicateActionList(KeyResult oldKeyResult, KeyResult newKeyResult) {
         List<Action> actionList = oldKeyResult.getActionList();
-        if (!actionList.isEmpty()) {
+        if (actionList != null) {
             actionList = actionList
                     .stream()
                     .map(e -> Action.Builder

diff --git a/backend/src/test/java/ch/puzzle/okr/service/business/ObjectiveBusinessServiceTest.java b/backend/src/test/java/ch/puzzle/okr/service/business/ObjectiveBusinessServiceTest.java
@@ -261,8 +261,11 @@ void shouldDuplicateMetricKeyResult() {
                 .build();
         KeyResult keyResultMetric = KeyResultMetric.Builder.builder().withTitle("Metric").build();
         objectiveBusinessService.duplicateKeyResult(authorizationUser, keyResultMetric, objective);
-        verify(objectiveBusinessService.makeCopyOfKeyResultMetric(keyResultMetric, objective), times(1));
-        verify(keyResultBusinessService.createEntity(keyResultMetric, authorizationUser), times(1));
+        verify(objectiveBusinessService, times(1))
+                .makeCopyOfKeyResultMetric(keyResultMetric, objective);
+
+        verify(keyResultBusinessService, times(1))
+                .createEntity(any(KeyResult.class), any(AuthorizationUser.class));
     }
 
     @DisplayName("Should duplicate ordinal key result")
@@ -275,8 +278,11 @@ void shouldDuplicateOrdinalKeyResult() {
                 .build();
         KeyResult keyResultOrdinal = KeyResultOrdinal.Builder.builder().withTitle("Ordinal").build();
         objectiveBusinessService.duplicateKeyResult(authorizationUser, keyResultOrdinal, objective);
-        verify(objectiveBusinessService.makeCopyOfKeyResultMetric(keyResultOrdinal, objective), times(1));
-        verify(keyResultBusinessService.createEntity(keyResultOrdinal, authorizationUser), times(1));
+        verify(objectiveBusinessService, times(1))
+                .makeCopyOfKeyResultOrdinal(keyResultOrdinal, objective);
+
+        verify(keyResultBusinessService, times(1))
+                .createEntity(any(KeyResult.class), any(AuthorizationUser.class));
     }
 
     @DisplayName("Should duplicate ActionList")