Fix a couple semantic tags and format code

puzzle · Oct 23, 2024 · d712ac1 · d712ac1
1 parent 63aae6e
commit d712ac1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/frontend/src/app/components/confidence/confidence.component.html b/frontend/src/app/components/confidence/confidence.component.html
@@ -7,7 +7,7 @@
     class="bg-inherit d-flex justify-content-center align-items-center"
     [ngClass]="[edit ? 'keyResult-attribute-edit' : 'keyResult-attribute-show', isDetail ? 'height' : '']"
   >
-    <span class="fw-normal text-black keyResult-overview-attribute" data-testid="confidence"
+    <span class="fw-normal text-black keyResult-overview-attribute" [attr.data-testId]="'confidence'"
       >{{ checkIn.confidence }}/{{ max }}</span
     >
   </div>

diff --git a/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.html b/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.html
@@ -11,9 +11,9 @@
 
     <form [formGroup]="completeForm">
       <div class="input-style gap-2 col-12">
-        <label class="text-black">Bewertung</label>
+        <p class="text-black">Bewertung</p>
         <div class="d-flex gap-3">
-          <span
+          <button
             class="successful w-50 valuation-card card-hover-successful"
             [ngClass]="{
               'active-successful': completeForm.value.isSuccessful == true,
@@ -25,8 +25,8 @@
             tabindex="0"
           >
             Objective erreicht
-          </span>
-          <span
+          </button>
+          <button
             class="not-successful w-50 valuation-card card-hover-not-successful"
             [ngClass]="{
               'active-not-successful': completeForm.value.isSuccessful === false,
@@ -38,7 +38,7 @@
             tabindex="0"
           >
             Objective nicht erreicht
-          </span>
+          </button>
         </div>
       </div>