Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1135 formatter #1159

Merged
merged 78 commits into from
Dec 20, 2024
Merged

Feature/1135 formatter #1159

merged 78 commits into from
Dec 20, 2024

Conversation

kcinay055679
Copy link
Collaborator

No description provided.

@kcinay055679 kcinay055679 self-assigned this Nov 15, 2024
@kcinay055679 kcinay055679 linked an issue Nov 15, 2024 that may be closed by this pull request
1 task
@ManuelMoeri ManuelMoeri force-pushed the feature/1135-formatter branch from 4270eb8 to 96c8316 Compare November 20, 2024 12:57
@kcinay055679 kcinay055679 force-pushed the feature/1135-formatter branch 3 times, most recently from 36a46eb to 9e45167 Compare November 22, 2024 11:01
backend/README.md Show resolved Hide resolved
frontend/tsconfig.json Outdated Show resolved Hide resolved
@kcinay055679
Copy link
Collaborator Author

should be rebased too

@Miguel7373 Miguel7373 force-pushed the feature/1135-formatter branch from b21142d to 90387c4 Compare November 26, 2024 06:37
@Miguel7373 Miguel7373 mentioned this pull request Nov 26, 2024
1 task
@Miguel7373
Copy link
Collaborator

Dies ist die config PR

wenn die config approved wurde, sollte zuerst die PR 1159-formatter-applyed
in dieses hinein gemerged zu werden. Da in der zweiten PR die changes des formatter sind.

@Miguel7373 Miguel7373 marked this pull request as ready for review November 26, 2024 10:48
@peggimann peggimann force-pushed the feature/1135-formatter branch from e9cfeb0 to ab019e6 Compare November 27, 2024 09:56
@RandomTannenbaum RandomTannenbaum marked this pull request as draft November 27, 2024 10:32
@kcinay055679 kcinay055679 force-pushed the feature/1135-formatter branch from b01bea4 to f459916 Compare November 28, 2024 14:37
@kcinay055679 kcinay055679 force-pushed the feature/1135-formatter branch 5 times, most recently from 70c60c5 to 52e59c4 Compare December 13, 2024 10:10
Copy link
Collaborator

@RandomTannenbaum RandomTannenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths containing white spaces are not yet handled correctly.

frontend/scripts/pre-commit Outdated Show resolved Hide resolved
@kcinay055679 kcinay055679 force-pushed the feature/1135-formatter branch 4 times, most recently from 02dc127 to 3805119 Compare December 20, 2024 11:38
@kcinay055679 kcinay055679 force-pushed the feature/1135-formatter branch from c2c0b37 to 7734450 Compare December 20, 2024 12:09
@kcinay055679 kcinay055679 marked this pull request as ready for review December 20, 2024 12:09
backend/pom.xml Outdated
</eclipse>
<removeUnusedImports />
<importOrder>
<order>java|javax,ch.puzzle,org,com,com.diffplug,,\#com.diffplug,\#</order>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe replace javax with jakarta

@peggimann peggimann merged commit 59a8d1e into main Dec 20, 2024
18 checks passed
@peggimann peggimann deleted the feature/1135-formatter branch December 20, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatter
4 participants