Bug/1255 Duplicating a objective does not bring all properties of the KeyResults #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
nevio18324
force-pushed
the
bug/1255-duplicating-of-objective-should-bring-all-properties
branch
from
d8561be to
f090a48
Compare
MasterEvarior
requested changes
Jan 15, 2025
backend/src/main/java/ch/puzzle/okr/service/business/ObjectiveBusinessService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/service/persistence/ActionPersistenceService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ch/puzzle/okr/service/business/ActionBusinessService.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/ch/puzzle/okr/service/persistence/ActionPersistenceServiceIT.java
Outdated
Show resolved
Hide resolved
peggimann
requested changes
Jan 15, 2025
| BDDMockito.given(keyResultMapper.toDto(any(KeyResultMetric.class), any())).willReturn(keyResultMetricDto); | ||
| BDDMockito.given(keyResultMapper.toDto(any(KeyResultOrdinal.class), any())).willReturn(keyResultOrdinalDto); | ||
| BDDMockito.given(objectiveAuthorizationService.getAuthorizationService()).willReturn(authorizationService); | ||
| BDDMockito.given(objectiveMapper.toDto(objective1)).willReturn(objective1Dto); | ||
| BDDMockito.given(objectiveMapper.toDto(any())).willReturn(objective1Dto); |
There was a problem hiding this comment.
be careful using any here, could lead to unexpected behavior. Generally it's considered to be best practice to mock as precise as possible.
| CompletedBusinessService completedBusinessService) { | ||
| CompletedBusinessService completedBusinessService, | ||
| ActionPersistenceService actionPersistenceService, | ||
| ActionBusinessService actionBusinessService) { |
There was a problem hiding this comment.
action business service should be enough there should be no need to use action persisstence service here
| } | ||
|
|
||
| List<Action> copiedActions = actionBusinessService.createDuplicateOfActions(keyResult, newKeyResult); |
There was a problem hiding this comment.
handle the entity in the actionBusinessService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.