Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1015 rework key result metric #1297

Merged
merged 51 commits into from
Jan 22, 2025

Conversation

kcinay055679
Copy link
Collaborator

No description provided.

@kcinay055679 kcinay055679 force-pushed the feature/1015-rework-key-result-metric branch 2 times, most recently from 2c48530 to bb1cbac Compare January 16, 2025 15:01
@kcinay055679 kcinay055679 marked this pull request as ready for review January 16, 2025 16:55
@kcinay055679 kcinay055679 self-assigned this Jan 16, 2025
Copy link
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autogenerated number should not have that many decimals after the period. Especially for the currencies, where there cannot be 1/100000 of a EUR/CHF/....
image

frontend/src/assets/i18n/de.json Outdated Show resolved Hide resolved
@MasterEvarior MasterEvarior linked an issue Jan 17, 2025 that may be closed by this pull request
2 tasks
MasterEvarior
MasterEvarior previously approved these changes Jan 17, 2025
@kcinay055679 kcinay055679 force-pushed the feature/1015-rework-key-result-metric branch from f3854d6 to e470100 Compare January 20, 2025 07:21
Copy link
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

@MasterEvarior MasterEvarior merged commit a889cc8 into main Jan 22, 2025
18 checks passed
@MasterEvarior MasterEvarior deleted the feature/1015-rework-key-result-metric branch January 22, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key Result Metrisch Überarbeiten / Einheit
5 participants