updated the way, users are compared while deletion (#160)

* updated the way, users are compared why deletion * added fragments * fixed typo
puzzle · Nov 7, 2024 · 5eef6d6 · 5eef6d6
1 parent 12c6e2e
commit 5eef6d6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelogs/fragments/160-fix-user-removal.yml b/changelogs/fragments/160-fix-user-removal.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+    - puzzle.opnsense.system_access_users - Thanks to @GBBx fixed a bug while user deletion.
diff --git a/plugins/module_utils/system_access_users_utils.py b/plugins/module_utils/system_access_users_utils.py
@@ -934,7 +934,7 @@ def delete(self, user: User) -> None:
             None: This method does not return a value but updates the internal list of users.
         """
 
-        self._users = [r for r in self._users if r != user]
+        self._users = [r for r in self._users if r.name != user.name]
 
     def find(self, **kwargs) -> Optional[User]:
         """