feat: update pifm.py for 'new' reader rules #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new pycroscopy has switched from Translators to Readers. We no longer save files in USID or NSID format in order to translate, but rather translate while reading from the file. The user can choose to save a given sidpy dataset into USID or NSID format after-the-fact, via those libraries. Here, we update the pifm module to match this new standard. As such, we remove the pyNSID dependencies and the write/create methods which use them.
|
Hi all, I'm not sure if this is the best approach to get pifm up-to-date, but I took a stab at it. It looks to me like all the failures are due to tests independent of my changes. Let me know what you think. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new pycroscopy has switched from Translators to Readers. We no longer save files in USID or NSID format in order to translate, but rather translate while reading from the file. The user can choose to save a given sidpy dataset into USID or NSID format after-the-fact, via those libraries.
Here, we update the pifm module to match this new standard. As such, we remove the pyNSID dependencies and the write/create methods which use them.