Move random functions to their own file #196
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes tools/g3c a slightly more manageable length. It also makes it easier to switch to the new numpy random API in future, which would solve our non-deterministic CI woes.
|
This pull request introduces 2 alerts when merging c7a5058 into aec1960 - view on LGTM.com new alerts:
|
eric-wieser
force-pushed
the
move-random
branch
from
c7a5058 to
9968d86
Compare
|
This pull request introduces 2 alerts when merging 9968d86 into aec1960 - view on LGTM.com new alerts:
|
|
Except I screwed up and CI fails. Some of the functions in |
|
Yeah this brings us to the difficult problem of moving between algebras... The tools in tools.g3 actually just use clifford.g3c as I had no really good way of mixing algebras. This is obviously not a dream situation. @arsenovic has a blade map setup but to my shame I never worked out how to use it |
|
Maybe it's time we opened this can of worms again #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes tools/g3c a slightly more manageable length.
It also makes it easier to switch to the new numpy random API in future, which would solve our non-deterministic CI woes.