-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pyodide handles #49
Conversation
Wow, thanks @hoodmane! I didn't look at the details yet but it looks very cool. I'll review this during weekends, or if it is not available, next Monday. |
I can change my PR when this one is merged. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks quite interesting, and overall LGTM. Though I'll let @ryanking13 do a second review.
Could you please add a changelog entry and an example to the readme on how to use this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @hoodmane! I have some minor comments, otherwise looks good to me.
Thanks again! Please update the changelog and add some examples in README if possible as Roman mentioned, then feel free to merge. I think we can release this with the tag 0.23.0. |
@ryanking13 ran into the problem in pyodide/pyodide#3184 (comment) that it's inconvenient to send results from one
@run_in_pyodide
invocation to another. This adds a mechanism to do so. ASeleniumHandle
(perhaps can be named better) can be returned to the host and when passed back into another@run_in_pyodide
function one can use it to access the object.This should allow us to make fixtures specifically for use with
@run_in_pyodide
functions that return one or moreSeleniumHandle
s.