Use literal file names in test_commands #1212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmavirus24
requested changes
Jan 10, 2025
dnicolodi
force-pushed
the
simplify-test_command
branch
from
41f44cc to
cdebaeb
Compare
There is no need for the strings to be real file paths and using string manipulation to build the file names is error prone. Define simple helpers that construct the file names as needed. This makes the tests intent and implementation easier to understand.
dnicolodi
force-pushed
the
simplify-test_command
branch
from
cdebaeb to
2f8f562
Compare
I think something is wrong in this sentence: I cannot really parse it. However, I agree that the tests as constructed are error prone, but I don't think there is a significant difference in how error prone is to construct the file names with string concatenation or using string literals. I now reworked this significantly to use helpers to construct the file names. Please have another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for the strings to be real file paths. Using string literals makes the test obvious to follow. This continues the work aimed at removing the binary test artifacts from the repository.