Skip to content

Commit

Permalink
Remove outdated comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ewjoachim committed Mar 22, 2021
1 parent 36be396 commit cd746f3
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions warehouse/macaroons/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,4 @@ class Macaroon(db.Model):
# scope of their macaroon is.
caveats = Column(JSONB, nullable=False, server_default=sql.text("'{}'"))

# It might be better to move this default into the database, that way we
# make it less likely that something does it incorrectly (since the
# default would be to generate a random key). However, it appears the
# PostgreSQL pgcrypto extension uses OpenSSL RAND_bytes if available
# instead of urandom. This is less than optimal, and we would generally
# prefer to just always use urandom. Thus we'll do this ourselves here
# in our application.
key = Column(LargeBinary, nullable=False)

0 comments on commit cd746f3

Please sign in to comment.