Add JSON user API #17352
Open
Add JSON user API #17352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `/user/{username}/json` and `/user/{username}/json/` routes
woodruffw
suggested changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks @Robin5605! I did a quick pass on this, a couple of comments inline.
(This review wasn't for approval of the feature itself, just quality. An actual maintainer will need to bless it.)
warehouse/routes.py
Outdated
Comment on lines
650
to
655
| config.add_route( | ||
| "legacy.api.json.user_slash", | ||
| "/user/{username}/json/", | ||
| factory="warehouse.legacy.api.json.user_factory", | ||
| domain=warehouse, | ||
| ) |
There was a problem hiding this comment.
Having a dedicates route for the slash variant seems a little funky (versus redirecting), but I see it's what we do for the other routes under legacy.api. Curious if @miketheman or @di has thoughts about this 🙂
There was a problem hiding this comment.
Agreed. For now I've just done what the other routes are doing but something cleaner would be nice.
Co-authored-by: William Woodruff <william@yossarian.net>
Co-authored-by: William Woodruff <william@yossarian.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15769
Some points of discussion:
/user/{username}? Or should we return other stuff as well?