fix(search): fallback to find packages for PyPI

[abn]

If not results are found when searching PyPI fallback to using the find package mechanism to at the minimum list any matches for valid PEP 508 specifications.

Resolves: #9884

Also includes a minor cleanup commit.

Summary by Sourcery

Bug Fixes:

• Fix an issue where searches against PyPI would return no results if the search functionality was unavailable.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request implements a fallback mechanism for PyPI searches. If the initial search yields no results, the code now attempts to find packages using find_packages to handle cases where PyPI search is unavailable. It also includes a minor cleanup of unused imports in the tests.

Sequence diagram for PyPI package search with fallback

sequenceDiagram
    participant Client
    participant PyPIRepository
    participant PyPI

    Client->>PyPIRepository: search(query)
    PyPIRepository->>PyPI: Initial search request
    alt Search successful
        PyPI-->>PyPIRepository: Return search results
        PyPIRepository-->>Client: Return packages
    else No results found
        PyPI-->>PyPIRepository: Empty results
        Note over PyPIRepository: Convert query to PEP 508
        PyPIRepository->>PyPI: find_packages(dependency)
        PyPI-->>PyPIRepository: Return matching packages
        PyPIRepository-->>Client: Return packages
    end

Loading

Flow diagram for PyPI search logic

flowchart TD
    A[Start Search] --> B{Search PyPI}
    B -->|Results found| C[Return Results]
    B -->|No results| D[Split query into tokens]
    D --> E[Process each token]
    E --> F{Valid PEP 508?}
    F -->|Yes| G[Find packages for dependency]
    F -->|No| H[Skip token]
    G --> I[Add to results]
    H --> J{More tokens?}
    I --> J
    J -->|Yes| E
    J -->|No| K[Return combined results]

Loading

File-Level Changes

Change	Details	Files
Implement fallback to find packages if PyPI search returns no results	Added a fallback mechanism to use find_packages if the initial PyPI search returns no results. Handles cases where PyPI search is unavailable, improving user experience.	src/poetry/repositories/pypi_repository.py
Add tests for fallback search functionality	Added tests to verify the fallback mechanism using various search queries. Tests cover scenarios with no matches, exact matches, range matches, partial matches, and invalid tokens. Parametrized tests to cover different search query types and expected result counts.	tests/repositories/test_pypi_repository.py
Add fixture for simulating unavailable PyPI search	Created a fixture with_disallowed_pypi_search_html to simulate scenarios where PyPI search is unavailable. Fixture intercepts search requests and returns a custom HTML response indicating search is disallowed. Allows testing the fallback mechanism without affecting actual PyPI searches.	tests/repositories/fixtures/pypi.py
Remove unused imports and variables	Removed unused imports and variables as part of a cleanup effort. Improved code readability and maintainability.	tests/console/commands/test_search.py
Add HTML file for simulating unavailable PyPI search	Added an HTML file that simulates a response from PyPI when search is unavailable. Used by the with_disallowed_pypi_search_html fixture to simulate the unavailable search scenario.	tests/repositories/fixtures/pypi.org/search/search-disallowed.html

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @abn - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}