feat: check response return codes after the error state

python-scim · Dec 8, 2024 · cb9cfee · cb9cfee
1 parent 83d52c8
commit cb9cfee
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/doc/changelog.rst b/doc/changelog.rst
@@ -1,6 +1,14 @@
 Changelog
 =========
 
+[0.5.1] - Unreleased
+--------------------
+
+Changed
+^^^^^^^
+- Check response return codes after the error state.
+  This helps providing more useful error messages.
+
 [0.5.0] - 2024-12-06
 --------------------
 

diff --git a/scim2_client/client.py b/scim2_client/client.py
@@ -265,7 +265,6 @@ def check_response(
         if raise_scim_errors is None:
             raise_scim_errors = self.raise_scim_errors
 
-        self._check_status_codes(status_code, expected_status_codes)
         self._check_content_types(headers)
 
         # In addition to returning an HTTP response code, implementers MUST return
@@ -283,6 +282,7 @@ def check_response(
             check_response_payload = self.check_response_payload
 
         if not check_response_payload:
+            self._check_status_codes(status_code, expected_status_codes)
             return response_payload
 
         if (
@@ -294,6 +294,8 @@ def check_response(
                 raise SCIMResponseErrorObject(obj=error.detail, source=error)
             return error
 
+        self._check_status_codes(status_code, expected_status_codes)
+
         if not expected_types:
             return response_payload