Skip to content

Commit

Permalink
Bring Box closer to Rect standards (#2485)
Browse files Browse the repository at this point in the history
* Imma get laaaaaaaazy.

* thanks @DragonMoffon for code review

* no, *your* line is too long

* ok how about now

* clean up box

* Henry Ford was an American industrialist and business magnate. As the--

* pushfoo: proofreading

* Add back missing module-level docstring?

* Reword and reformat top-level box docstring

* Update arcade/types/box.py

Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>

* fix missed rectplacement

* Add Box to the quick index

* Bug fix for Rect and Box init helpers

* Add capital letters to accepted function regex

* Add comment explaining in-depth why and where we need the feature

* Formatting to make True, 0, and False code literals

* Add missing docstring for box.point_in_box

---------

Co-authored-by: pushfoo <36696816+pushfoo@users.noreply.github.com>
  • Loading branch information
DigiDuncan and pushfoo authored Jan 9, 2025
1 parent 26af9ff commit 0d0ee61
Show file tree
Hide file tree
Showing 3 changed files with 417 additions and 10 deletions.
8 changes: 5 additions & 3 deletions arcade/types/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,18 @@

# Boxes
from arcade.types.box import Box
from arcade.types.box import LBNWHD
from arcade.types.box import LRBTNF
from arcade.types.box import XYZWHD


__all__ = [
"AsFloat",
"BufferProtocol",
"Box",
"XYZWHD",
"LRBTNF",
"LBNWHD",
"Color",
"IntRectParams",
"IPoint",
Expand All @@ -121,9 +126,6 @@
"Viewport",
"RectParams",
"RectKwargs",
"Box",
"LRBTNF",
"XYZWHD",
"HasAddSubMul",
"RGB",
"RGBA",
Expand Down
Loading

0 comments on commit 0d0ee61

Please sign in to comment.