Fix video embeds, columns, and resource link breakage #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per einarf's feedback:
|
|
TL;DR: Feedback from Digi is incorporated, but perfect file copying will follow later since there's loads more stuff to do Getting folder copying "right" is less important than:
We also have the following upstream changes to take care of now when it's ok to break API:
|
* Run create_resources_listing.py via main() instead of as __main__ * Move git ref and version read earlier in conf.py * Template in globals via init_globals instead of complicated passing * Encapsulate runpath.run_py call with default args
* Remove redundant variable * Stop doing repeated . access on path.suffix * Compact the audio file embeds to use a dict * Remove cruft from GLSL (it's not an audio file)
* For n < 3 files, reduce the number of columns * Actually use video embeds * Link GitHub pages for Tiled map .json
* Add comments * Remove unused vars * Move config closer to top
* Set top-level pathlib.Path-based constants * Use absolute paths as the base for the util runs * Add a DRY helper
pushfoo
force-pushed
the
fix-dev-branch-urls
branch
from
af972bc to
920f1ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Fixes most if not all of #2387 for
development+ add video embeds plus some copyable string literalsChanges
There are a whole bunch.
":resources:sounds/jump3.wav"literals for sounds and videosFollow-up work
Switch to a copy-based approach for true long-term durability.