Add Liberation font family to Arcade #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR is fine, but I do like the idea of Liberation Sans being the default font. |
|
The resources listing is (once again) broken because it assumes a lot about how Arcade is built. I don't have time to fix this tonight and might not in the next few days. |
pushfoo
force-pushed
the
add-liberation-font-family
branch
2 times, most recently
from
fe2c7ff to
8a88b65
Compare
|
I've rebased this and I'm looking at an acceptable short-term fix to get 3.0 moving. |
eruvanos
reviewed
Jan 10, 2025
* Add Liberation font TTFs (Generic versions of Arial, Courier, and Times) * Add OFL license in new folder * Add load function modeled after load_kenney_fonts
* Add Liberation font loading to text drawing examples * Add comments explaining usage of fonts * Fix typo (s/bumbled/bundled/)
* Add initial graphic courtesy of @DigiDuncan * Add SIL Open Font License to links.rst * Add basic inset for the Liberation fonts * Add printing for the Liberation font info + SIL link
pushfoo
force-pushed
the
add-liberation-font-family
branch
from
8a88b65 to
b7e775a
Compare
|
I would be fine with merging it, looks good to me and as far as I understood it, we can go with the pre-generated image for the fonts, that is fine for now. |
pushfoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Add Liberation font files per #1011 and #1135 per call with Digi and Eruvanos
Changes
Questions