Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various cython related compile errors #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

poke1024
Copy link

Should fix #35, #34, #31.

Tested with python 3.7.3 (macOS) and python 2.7.10 (macOS).

With latest Python 3 things compile without warnings (see the four included int casts in ranged for loops).

@poke1024
Copy link
Author

Travis fails due to not having cython installed.

@poke1024 poke1024 force-pushed the fix-cython-py3 branch 2 times, most recently from 7fed0ab to 1c27aa8 Compare April 22, 2019 03:21
tested with python 3.7.3 and python 2.7.10
@poke1024
Copy link
Author

Fixed Travis: removed support for Python 3.2, added Python 3.5 and Python 3.6. Python 3.7 is not yet supported by Travis out of the box.

@dbuscaglia
Copy link

Why is this not merged?

@markanewman
Copy link

No issues so far with Python 3.7.4 on win10 using IntDAWG

@@ -1,6 +1,7 @@
#! /usr/bin/env python
import glob
from setuptools import setup, Extension
from Cython.Build import cythonize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @poke1024! I think dawg shouldn't require cython as install dependency.

@hzitoun
Copy link

hzitoun commented Oct 21, 2019

This PR should be merged as the referenced issues are still happening :

  • MacOS High Sierra 10.13.6
  • Python 3
  • Anaconda 3
Command "/anaconda3/bin/python -u -c "import setuptools, tokenize;__file__='/private/var/folders/9v/XXXXXXX/T/pip-install-jf78ea1b/DAWG/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /private/var/folders/9v/XXXXXXX0000gp/T/pip-record-adzwmina/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /private/var/folders/9v/XXXXXXX2pjth0000gp/T/pip-install-jf78ea1b/DAWG/

@kmike
Copy link
Member

kmike commented Oct 21, 2019

@hzitoun could you please try installing from github? I've updated DAWG to support recent Pythons, but haven't made a release yet.

@hzitoun
Copy link

hzitoun commented Oct 21, 2019

@kmike I'm trying. I'll keep you informed/

@hzitoun
Copy link

hzitoun commented Oct 21, 2019

So after updating everything (conda update --all), installing from github works! so thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build DAWG Mac
5 participants