-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various cython related compile errors #36
base: master
Are you sure you want to change the base?
Conversation
Travis fails due to not having |
7fed0ab
to
1c27aa8
Compare
tested with python 3.7.3 and python 2.7.10
1c27aa8
to
1c33d61
Compare
Fixed Travis: removed support for Python 3.2, added Python 3.5 and Python 3.6. Python 3.7 is not yet supported by Travis out of the box. |
Why is this not merged? |
No issues so far with Python 3.7.4 on win10 using |
@@ -1,6 +1,7 @@ | |||
#! /usr/bin/env python | |||
import glob | |||
from setuptools import setup, Extension | |||
from Cython.Build import cythonize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @poke1024! I think dawg shouldn't require cython as install dependency.
This PR should be merged as the referenced issues are still happening :
|
@hzitoun could you please try installing from github? I've updated DAWG to support recent Pythons, but haven't made a release yet. |
@kmike I'm trying. I'll keep you informed/ |
So after updating everything ( |
Should fix #35, #34, #31.
Tested with python 3.7.3 (macOS) and python 2.7.10 (macOS).
With latest Python 3 things compile without warnings (see the four included
int
casts in rangedfor
loops).