Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish results #4

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Publish results #4

wants to merge 5 commits into from

Conversation

adybbroe
Copy link
Contributor

This PR adds the publication of the resulting files. Also all references to "SIR" is now removed. Files that passes the filter (on area coverage) are stored in a destination directory and Posttroll messages are published.

Adam.Dybbroe added 2 commits July 18, 2023 14:54
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe adybbroe self-assigned this Jul 18, 2023
Adam.Dybbroe added 2 commits July 18, 2023 18:40
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this and taking the opportunity to refactor a bit. Any change we get a test for this feature?

pytroll_product_filter/main.py Outdated Show resolved Hide resolved
pytroll_product_filter/main.py Outdated Show resolved Hide resolved
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
@adybbroe
Copy link
Contributor Author

Thanks for working on this and taking the opportunity to refactor a bit. Any change we get a test for this feature?

Yeah, it is a valid question. The project is so far untested! However, I think the project can be closed soon and its functionality be replaced by a Pytroll gatherer and a file dispatcher. So, I am not so keen on spending much more effort on this code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants