Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few minor issues raised in PR93 which were accidentally left out #95

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

adybbroe
Copy link
Contributor

@adybbroe adybbroe commented Jan 8, 2025

This PR fixes a few small things that I forgot to push before closing and merging PR93. The issues were raised by the reviewers and postulated to be fixed successfully, but apparently forgotten.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe adybbroe self-assigned this Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.42%. Comparing base (6d8344f) to head (890e760).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   60.35%   60.42%   +0.06%     
==========================================
  Files          18       18              
  Lines        2278     2274       -4     
==========================================
- Hits         1375     1374       -1     
+ Misses        903      900       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adybbroe adybbroe merged commit e24583d into pytroll:main Jan 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant