Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ESSL colorisation approach #3021

Merged
merged 6 commits into from
Jan 20, 2025
+130 −198

Add imagery tests for colorized low level moisture

cc850ab
Select commit
Loading
Failed to load commit list.
Merged

Change ESSL colorisation approach #3021

Add imagery tests for colorized low level moisture
cc850ab
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 17, 2025 in 34s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.00 (9.83 -> 9.83)

View detailed results in CodeScene

Details

Annotations

Check notice on line 76 in satpy/tests/behave/features/steps/image_comparison.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Excess Number of Function Arguments 

step_when_generate_image increases from 6 to 7 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
View more details on CodeScene Delta Analysis