Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write datapackage.json to WACZ upon creation #15

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

leewesleyv
Copy link
Collaborator

@leewesleyv leewesleyv commented Oct 22, 2024

Resolves #12

For the description and software attributes of the datapackage I've generated a semi-static string. Let's check this and see if this makes sense for the owner/user of the WACZ file.

  • @wvengen Review datapackage.json attributes/values
  • @leewesleyv Add unittest for datapackage.json generation

@leewesleyv leewesleyv self-assigned this Oct 22, 2024
@leewesleyv leewesleyv requested a review from wvengen October 22, 2024 15:01
Copy link
Member

@wvengen wvengen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast! Thanks :)
Some notes, otherwise seems fine.
Would be good to test the hasing implementation to see if the hash is indeed correctly computed (there can sometimes be subtle details).

scrapy_webarchive/utils.py Outdated Show resolved Hide resolved
scrapy_webarchive/wacz.py Outdated Show resolved Hide resolved
scrapy_webarchive/wacz.py Outdated Show resolved Hide resolved
scrapy_webarchive/wacz.py Outdated Show resolved Hide resolved
scrapy_webarchive/utils.py Outdated Show resolved Hide resolved
scrapy_webarchive/wacz.py Outdated Show resolved Hide resolved
scrapy_webarchive/wacz.py Outdated Show resolved Hide resolved
@leewesleyv leewesleyv force-pushed the feature/12-datapackage-json-in-wacz branch from 31b192f to 69b2ad5 Compare October 28, 2024 10:15
@leewesleyv leewesleyv merged commit 9ea5f71 into main Oct 28, 2024
8 checks passed
@leewesleyv leewesleyv deleted the feature/12-datapackage-json-in-wacz branch October 28, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete datapackage.json in WACZ
2 participants