refactor(server/consumables): remove unused Player variable
#480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've done all I know |
Qwerty1Verified
suggested changes
Nov 14, 2024
server/logs.lua
Outdated
| @@ -86,6 +85,7 @@ RegisterNetEvent('qb-log:server:CreateLog', function(name, title, color, message | |||
| logQueue[name][#logQueue[name] + 1] = { webhook = webHook, data = embedData } | |||
|
|
|||
| if #logQueue[name] >= 10 then | |||
| local postData = {} | |||
There was a problem hiding this comment.
Try initialising postData as nil, or no value.
There was a problem hiding this comment.
Seems that this change does not fix the "issue"
Qwerty1Verified
suggested changes
Nov 15, 2024
server/logs.lua
Outdated
| @@ -86,6 +85,7 @@ RegisterNetEvent('qb-log:server:CreateLog', function(name, title, color, message | |||
| logQueue[name][#logQueue[name] + 1] = { webhook = webHook, data = embedData } | |||
|
|
|||
| if #logQueue[name] >= 10 then | |||
| local postData = nil | |||
There was a problem hiding this comment.
Try initialising it with our else data, and append content if tag is true (postData.content = '@everyone'). This means the else block wouldn't be needed.
local postData = { username = 'QB Logs', embeds = {} }
There was a problem hiding this comment.
thanks for your comment!!
|
OHHH YES, finally!!! |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Qwerty1Verified
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Pull request
This PR attempts to fix all linting errors of the smallresources script. There is still one error to be fixed, I would really thank any help.
If your PR is to fix an issue mention that issue here: No
Questions (please complete the following information):