Use better icons for RSS articles

[glassez]

Closes #20579.

[xavier2k6]

@glassez I just noticed....you are keeping the alternative name to just sphere & not sphere/sphere2 like it was in 4.2.x branch.

qBittorrent/src/gui/rss/articlelistwidget.cpp

Lines 124 to 130 in 2c65b79

	if (article->isRead()) {
	item->setData(Qt::ForegroundRole, QPalette().color(QPalette::Inactive, QPalette::WindowText));
	item->setData(Qt::DecorationRole, QIcon(":/icons/sphere.png"));
	}
	else {
	item->setData(Qt::ForegroundRole, QPalette().color(QPalette::Active, QPalette::Link));
	item->setData(Qt::DecorationRole, QIcon(":/icons/sphere2.png"));

Is that deliberate?

[glassez]

@glassez I just noticed....you are keeping the alternative name to just sphere & not sphere/sphere2 like it was in 4.2.x branch.

qBittorrent/src/gui/rss/articlelistwidget.cpp

Lines 124 to 130 in 2c65b79

	if (article->isRead()) {
	item->setData(Qt::ForegroundRole, QPalette().color(QPalette::Inactive, QPalette::WindowText));
	item->setData(Qt::DecorationRole, QIcon(":/icons/sphere.png"));
	}
	else {
	item->setData(Qt::ForegroundRole, QPalette().color(QPalette::Active, QPalette::Link));
	item->setData(Qt::DecorationRole, QIcon(":/icons/sphere2.png"));

Is that deliberate?

Sure.
I've always been in favor of naming icons based on their IDs.
I'm sorry, I didn't understand the essence of the question right away. I get it now.

Now "alternative name" only makes sense for icons from the Linux system theme. I'm not even sure if there's "sphere" icon there. Note that the old code (4.2.x) used only the built-in icons for this purpose even if Linux system theme icons were enabled. Perhaps we could just delete this alternate name but I don't want to touch it now.

[sledgehammer999]

Please try to give some minimal text/reasoning to a PR you open.
Like what is the source of the new assets? Does it need mentioning in AUTHORS ?

[glassez]

Please try to give some minimal text/reasoning to a PR you open.

I supposed that it makes no sense to duplicate the information that is already in the linked Issue.

Like what is the source of the new assets? Does it need mentioning in AUTHORS ?

They were extracted from previous qBittorrent resources.