Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh custom colors once color scheme is changed #20588

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

glassez
Copy link
Member

@glassez glassez commented Mar 21, 2024

Some icons were also affected (those that are located in the same scope of the code with the custom colors).

@glassez glassez added the GUI GUI-related issues/changes label Mar 21, 2024
@glassez glassez added this to the 5.0 milestone Mar 21, 2024
@glassez glassez requested a review from a team March 21, 2024 14:14
@glassez glassez marked this pull request as ready for review March 21, 2024 14:14
@xavier2k6
Copy link
Member

tested, all seems ok - only issue left still is the normal message in execution log not changing from light/dark & vice-versa while running.

@glassez
Copy link
Member Author

glassez commented Mar 21, 2024

only issue left still is the normal message in execution log not changing from light/dark & vice-versa while running.

Are you sure you tested the latest push? It works as expected for me.

@xavier2k6
Copy link
Member

Are you sure you tested the latest push?

Ya, Will power cycle system & test again/post vid.

@glassez
Copy link
Member Author

glassez commented Mar 21, 2024

@xavier2k6
I tested the build with GitHub. It really behaves incorrectly. It looks like Qt 6.5 (used on GitHub CI) sends a colorSchemeChanged signal before the QApplication palette is changed. I'll try to work around it...

@xavier2k6
Copy link
Member

Latest commit fixes it for me. 👍

xavier2k6
xavier2k6 previously approved these changes Mar 22, 2024
@glassez

This comment was marked as resolved.

@glassez glassez merged commit ce013f1 into qbittorrent:master Mar 23, 2024
13 checks passed
@glassez glassez deleted the custom-colors branch March 23, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants