Update User-Agent

[cayenne17]

Proposal fix problem download RSS feed fil : #13446

I changed the user agent

I'm not a developer

[xavier2k6]

I'm not sure if we should use latest "Firefox" agent as we still support Latest active ESR release for Firefox.

https://github.com/qbittorrent/qBittorrent/tree/master/src/webui/www#browser-compatibility

The latest user agents for Safari
The latest user agents for Chrome
The latest user agents for Firefox
The latest user agents for Edge

[cayenne17]

@xavier2k6 : So we're using Firefox version 115 instead?
The code I've modified concerns HTTP/HTTPS requests and not restrictions?

[glassez]

I'm not sure if we should use latest "Firefox" agent as we still support Latest active ESR release for Firefox.

I don't think it's related. It's just what user-agent qBittorrent appears to be when making HTTP requests.

[xavier2k6]

So we're using Firefox version 115 instead?

That's what my thoughts were initially but you can disregard it now.

[xavier2k6]

It's just what user-agent qBittorrent appears to be when making HTTP requests.

I was just thinking along the lines of that we could've used the ESR agent still supported ie 115 or we could've made it random from a list of user-agents from the supported browsers but "Yes, I was over-thinking/over-complicating a simple solution"

[glassez]

It would be nice to use something that would not require updating this hardcoded version too often.

[cayenne17]

@glassez https://product-details.mozilla.org/1.0/firefox_versions.json
before the build, retrieve the latest ESR version and modify the code dynamically?

[xavier2k6]

Bump to 1.44

qBittorrent/src/searchengine/nova3/helpers.py

Line 1 in 79eb7b8

#VERSION: 1.43

---

It would be nice to use something that would not require updating this hardcoded version too often.

(~5yrs ago) was last time agent string was updated, in PR #11049

[cayenne17]

Bump to 1.44

qBittorrent/src/searchengine/nova3/helpers.py

Line 1 in 79eb7b8

#VERSION: 1.43

It would be nice to use something that would not require updating this hardcoded version too often.

(~5yrs ago) was last time agent string was updated, in PR #11049

I've just made a commit to change the version number

[glassez]

@cayenne17
Thank you!

[cayenne17]

@glassez @xavier2k6 : when is the patch due to be deployed on 4.6.x?

It hasn't been deployed on version 4.6.5, which was released after this PR was merged.

[xavier2k6]

@glassez Please add this to #21035 Ref.: #20864 (comment) & it will close ticket #13446

[glassez]

@glassez Please add this to #21035 Ref.: #20864 (comment) & it will close ticket #13446

Done.