Avoid redundant requests of announce entries from libtorrent #21949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalieht
approved these changes
Dec 3, 2024
xavier2k6
approved these changes
Dec 4, 2024
|
Seems like this change has a serious negative side effect. Steps to reproduce:
The tracker remains in |
|
Although, the client does send a network request. But the status remains Reverting this commit fixes the issue. |
|
@HanabishiRecca |
|
Seems to be working now. |
|
@HanabishiRecca good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schedule request of announce entries of torrent and skip subsequent requests until existing one is done. Otherwise, they can flock in the queue until
libtorrentis free to execute them, which leads to multiple overwriting of tracker entry statuses with identical (or even obsolete) data.