Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eXact Length parameter when creating magnet URI #21958

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

antanilol
Copy link
Contributor

@antanilol antanilol commented Dec 5, 2024

Include the xl (eXact Length) parameter in the magnet URI string inside the function TorrentImpl::createMagnetURI().

Closes #20752.

@antanilol antanilol changed the title Add eXact Length parameter to magnet uri, solves #20752 Add eXact Length parameter to magnet uri, closes #20752 Dec 5, 2024
@thalieht
Copy link
Contributor

thalieht commented Dec 6, 2024

This just adds the parameter to "Copy magnet link". qBt won't read it for any purpose (in the current state of the PR).
Is that useful for anything?

Also isn't this just a "promise"? It could be fake so, assuming qBt implements reading it, users will add the magnet link expecting a certain size, forget about it and come back to see a different size (once metadata has been downloaded to get the actual size).

@antanilol
Copy link
Contributor Author

Is that useful for anything?

Many trackers I know (at least 4) provide only the magnet links and not the torrent file, so, in my opinion this would help the automated systems (like Jackett, prowlarr) to get this information.

Also isn't this just a "promise"? It could be fake

Yes, like the display name parameter, after all. I don't think this simple change could hurt anyone.

Also, I don't see why anyone would fake this information

@Chocobo1 Chocobo1 changed the title Add eXact Length parameter to magnet uri, closes #20752 Add eXact Length parameter to magnet URI Dec 6, 2024
@Chocobo1 Chocobo1 added the Core label Dec 6, 2024
@Chocobo1 Chocobo1 added this to the 5.1 milestone Dec 6, 2024
Chocobo1
Chocobo1 previously approved these changes Dec 6, 2024
@Chocobo1 Chocobo1 changed the title Add eXact Length parameter to magnet URI Add eXact Length parameter when creating magnet URI Dec 6, 2024
@Chocobo1 Chocobo1 requested a review from a team December 6, 2024 13:02
@Chocobo1 Chocobo1 merged commit 2745146 into qbittorrent:master Dec 8, 2024
14 checks passed
@Chocobo1
Copy link
Member

Chocobo1 commented Dec 8, 2024

@antanilol
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include torrent size in magnet link
4 participants