Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify captured variable type #22102

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Simplify captured variable type #22102

merged 1 commit into from
Jan 6, 2025

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Jan 4, 2025 •
edited
Loading

By capturing the specific data instead of torrent handle the lambda can become non-mutable.

@Chocobo1 Chocobo1 added the Code cleanup Clean up the code while preserving the same outcome label Jan 4, 2025
@Chocobo1 Chocobo1 added this to the 5.1 milestone Jan 4, 2025
@Chocobo1 Chocobo1 mentioned this pull request Jan 4, 2025
Closed
glassez
glassez previously approved these changes Jan 4, 2025
View reviewed changes
@Chocobo1 Chocobo1 changed the title Move construct captured data Simplify captured variable type Jan 4, 2025
@Chocobo1
Copy link
Member Author

Chocobo1 commented Jan 4, 2025 •
edited
Loading

PR updated. I noticed the inner lambda can just capture torrentHandle.info_hash() instead of torrentHandle and therefore the lambda doesn't need mutable anymore.

@Chocobo1 Chocobo1 requested a review from a team January 4, 2025 13:22
@Chocobo1
Simplify captured variable type
4178626 
By capturing the specific data instead of torrent handle the lambda can become non-mutable.
@Chocobo1 Chocobo1 merged commit 22e156e into qbittorrent:master Jan 6, 2025
14 checks passed
@Chocobo1 Chocobo1 deleted the capture_this branch January 6, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glassez glassez glassez approved these changes

Assignees
No one assigned
Labels
Code cleanup Clean up the code while preserving the same outcome
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Chocobo1 @glassez