Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Remove unnecessary hashing #22103

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Jan 4, 2025

Now the containers support using string as key so the intermediate hashing/mapping to number isn't needed now.

@Chocobo1 Chocobo1 added WebUI WebUI-related issues/changes Code cleanup Clean up the code while preserving the same outcome labels Jan 4, 2025
@Chocobo1 Chocobo1 added this to the 5.1 milestone Jan 4, 2025
@Chocobo1 Chocobo1 requested a review from a team January 4, 2025 13:20
@thalieht
Copy link
Contributor

thalieht commented Jan 4, 2025

Changing a category's save path collapses the categories section in the side filters and can't restore it. Also torrent list context menu doesn't open after this. Refreshing the page fixes them.

@glassez
Copy link
Member

glassez commented Jan 4, 2025

Changing a category's save path collapses the categories section in the side filters and can't restore it. Also torrent list context menu doesn't open after this. Refreshing the page fixes them.

@Chocobo1
I hope you won't ruin WebUI with such changes on the eve of v5.1 release.
I mean, it might be worth delaying risky changes.

Now the containers support using string as key so the intermediate hashing/mapping to number
isn't needed now.
@Chocobo1
Copy link
Member Author

Chocobo1 commented Jan 4, 2025

Changing a category's save path collapses the categories section in the side filters and can't restore it. Also torrent list context menu doesn't open after this. Refreshing the page fixes them.

Thanks! Fixed.

I mean, it might be worth delaying risky changes.

IMO this is only a moderate clean up. I'm more afraid of the diverge of stable branch and master branch that cause backport PRs to fail silently or harder to apply. Also we freeze new features only since RC is released, isn't?

@glassez
Copy link
Member

glassez commented Jan 4, 2025

Also we freeze new features only since RC is released, isn't?

Yes. But the state of the codebase needs to be stable enough for RC to be released, so we should be more restrained at this stage of the release cycle.
Hopefully, the above problems were the result of a minor oversight, and not an indicator of the difficult-to-predict consequences of this "moderate clean up".
(Just a word of caution. I didn't delve into it much.)

@Chocobo1 Chocobo1 merged commit d911928 into qbittorrent:master Jan 6, 2025
14 checks passed
@Chocobo1 Chocobo1 deleted the webui_hash branch January 6, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code cleanup Clean up the code while preserving the same outcome WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants