Add "% Selected" column to transfer list #22131
Open
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glassez
changed the title
thalieht
reviewed
Jan 9, 2025
| @@ -194,6 +194,7 @@ QVariant TransferListModel::headerData(const int section, const Qt::Orientation | |||
| case TR_INFOHASH_V2: return tr("Info Hash v2", "i.e: torrent info hash v2"); | |||
| case TR_REANNOUNCE: return tr("Reannounce In", "Indicates the time until next trackers reannounce"); | |||
| case TR_PRIVATE: return tr("Private", "Flags private torrents"); | |||
| case TR_PERCENT_SELECTED: return tr("% Selected", "Percentage of torrent selected"); | |||
There was a problem hiding this comment.
% Selected
Don't know about others but for me, what comes to mind is percentage of files selected not percentage of size.
| @@ -443,6 +444,8 @@ QString TransferListModel::displayValue(const BitTorrent::Torrent *torrent, cons | |||
| return reannounceString(torrent->nextAnnounce()); | |||
| case TR_PRIVATE: | |||
| return privateString(torrent->isPrivate(), torrent->hasMetadata()); | |||
| case TR_PERCENT_SELECTED: | |||
| return QString::number((torrent->wantedSize() * 100) / torrent->totalSize()) + u'%'; | |||
There was a problem hiding this comment.
Should show "N/A" when torrent doesn't have metadata.
thalieht
reviewed
Jan 9, 2025
| @@ -107,6 +107,12 @@ QVariantMap serialize(const BitTorrent::Torrent &torrent) | |||
| : (QDateTime::currentSecsSinceEpoch() - timeSinceActivity); | |||
| }; | |||
|
|
|||
| const auto getSelectedPercentage = [&torrent]() -> QString | |||
| { | |||
| auto percent = ((torrent.wantedSize() * 100)/torrent.totalSize()); | |||
There was a problem hiding this comment.
Suggested change
| auto percent = ((torrent.wantedSize() * 100)/torrent.totalSize()); | |
| auto percent = ((torrent.wantedSize() * 100) / torrent.totalSize()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22087.
Description
A new column that displays the % of selected data from a torrent.
Its meant to make it easier to distinguish and manage partial torrents as described in the issue.
UI images
Two partial picture of the UI follow, first is from Desktop app (Linux) second is from WebUI (Linux, Mozilla)
Example use case
You download a few episodes of series or files and want to determine by the first files if its worth downloading the whole torrent. In the presence of multiple torrents it might become bothersome to seek out those partial ones.
With this column you could go in
Completedand order by% Selectedascending, which would put the partial torrents on top. From there on its up to the user.