This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Move mention of download in progress at h2 level #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelazJ
commented
Nov 30, 2023
| @@ -96,9 +96,8 @@ | |||
| } | |||
| else if (currentPage.match(/site\/forusers\/(download|alldownloads)\.html/g)){ | |||
| $($('body')[0]).append('<div id="thankyou"> <div id="thankyoucontent">'+ | |||
| '<h2>{{ _("Thank you!") }}</h2> <p/>'+ | |||
| '<h2>{{ _("Thank you! Your freshly baked copy of QGIS is downloading.") }}</h2> <p/>'+ | |||
There was a problem hiding this comment.
Suggested change
| '<h2>{{ _("Thank you! Your freshly baked copy of QGIS is downloading.") }}</h2> <p/>'+ | |
| '<h2>{{ _("Thank you! Your freshly baked copy of QGIS is downloading...") }}</h2> <p/>'+ |
| '<div class="container"><div class="span8">'+ | ||
| '<p><b>{{ _("Your freshly baked copy of QGIS is downloading.") }}</b></p>'+ | ||
| '<p>{{ _("QGIS is free of charge, and will always be free of charge if downloaded from QGIS.org.") }}</p>'+ |
There was a problem hiding this comment.
Suggested change
| '<p>{{ _("QGIS is free of charge, and will always be free of charge if downloaded from QGIS.org.") }}</p>'+ | |
| '<p>{{ _("Due to the file size the download may take some time. Please be patient.") }}</p>'+ | |
| '<p>{{ _("QGIS is free of charge, and will always be free of charge if downloaded from QGIS.org.") }}</p>'+ |
strk
approved these changes
Jan 25, 2024
|
One of the drawbacks of doing this very small edits on such important pages, is that all translations break. I've discussed this with Harrissou in a remote session (and told him that I'm not in favour of pulling this, because this message is important). But others can (or if @DelazJ really wants this, I will do (or he can do himself)). PS: another reason not to edit such important pages (anymore) is that QGIS is busy with a new website(design/content). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a big "Thank you". Let's complete with information that the download is ongoing...