Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section about the symbol's extent buffer #9568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JuhoErvasti
Copy link

@JuhoErvasti JuhoErvasti commented Jan 17, 2025

Goal: Add a new section to the Vector Properties Dialog document about the extent buffer added in qgis/QGIS#59630

Ticket(s): fixes #9461

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JuhoErvasti
May I suggest you to move the whole section above the "Draw effects" section, close to the other items that are in the "Advanced" menu?
Also you'd need to reference this feature in https://docs.qgis.org/testing/en/docs/user_manual/style_library/symbol_selector.html#the-symbol, as part of a symbol level property.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get what we want to show here, in relation with the feature? Filling data-defined widget? I really much prefer the gif in the issue report showing the feature in play in the map canvas. Or it can just be an image from that gif when we have features showing their buffer but not the actual point and others showing both.
Also there are request for modifying/renaming that dialog (qgis/QGIS#60017, qgis/QGIS#60010) so IMHO the less we show it the less outdated we will look (description is often easier to adjust).

@@ -1310,6 +1310,34 @@ symbol, following some rules:

.. _vector_labels_tab:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This row acts as a shortcut throughout the docs to the vector label section that starts just after and nothing should be in-between. Or it would reference a wrong section.

@@ -1310,6 +1310,34 @@ symbol, following some rules:

.. _vector_labels_tab:

Extent buffer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a dedicated shortcut

Suggested change
Extent buffer
.. _extent_buffer:
Extent buffer


The buffer distance units can be changed. You can also control the distance value
by using the data defined override widget. For example you can change the value
based on the current map scale ``if(@map_scale > 50000, 5000, 0)``:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioning this is great as I also wondered what the DD button could be about before I read docs in implementation. But not sure it deserves a screncast.

:align: center
:width: 50%

Setting the symbol's extent buffer according to data defined expression
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show another type of example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configurable extent buffer to symbols (Request in QGIS)
2 participants