Skip to content

Commit

Permalink
qgsnewhttpconnection: Always enable paging options for WFS 1.1
Browse files Browse the repository at this point in the history
Paging support is only handled by WFS 2.0. However, some servers
handle paging even if they only expose WFS 1.1. At the moment, when
changing the version number, it has the following effect on the paging
options:
- "maximum": both options can be enabled
- "2.0": both options can be enabled
- "1.1": both options can be enabled
- "1.0": "feature paging" option is always disabled but the "page
size" option can be enabled

With this change, both paging options can be enabled for version
1.1. This allows to try to enable paging for WFS 1.1 if the server
handles it.
  • Loading branch information
ptitjano authored and github-actions[bot] committed Jan 14, 2025
1 parent a04cc6b commit 56b97dd
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/gui/qgsnewhttpconnection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,10 @@ QgsNewHttpConnection::QgsNewHttpConnection( QWidget *parent, ConnectionTypes typ
void QgsNewHttpConnection::wfsVersionCurrentIndexChanged( int index )
{
// For now 2019-06-06, leave paging checkable for some WFS version 1.1 servers with support
cmbFeaturePaging->setEnabled( index == WFS_VERSION_MAX || index >= WFS_VERSION_2_0 );
const bool pagingNotDisabled = cmbFeaturePaging->currentIndex() != static_cast<int>( QgsNewHttpConnection::WfsFeaturePagingIndex::DISABLED );
lblPageSize->setEnabled( pagingNotDisabled && ( index == WFS_VERSION_MAX || index >= WFS_VERSION_1_1 ) );
txtPageSize->setEnabled( pagingNotDisabled && ( index == WFS_VERSION_MAX || index >= WFS_VERSION_1_1 ) );
const bool pagingOptionsEnabled = ( index == WFS_VERSION_MAX || index >= WFS_VERSION_1_1 );
cmbFeaturePaging->setEnabled( pagingOptionsEnabled );
lblPageSize->setEnabled( pagingOptionsEnabled );
txtPageSize->setEnabled( pagingOptionsEnabled );
cbxWfsIgnoreAxisOrientation->setEnabled( index != WFS_VERSION_1_0 && index != WFS_VERSION_API_FEATURES_1_0 );
cbxWfsInvertAxisOrientation->setEnabled( index != WFS_VERSION_API_FEATURES_1_0 );
wfsUseGml2EncodingForTransactions()->setEnabled( index == WFS_VERSION_1_1 );
Expand Down

0 comments on commit 56b97dd

Please sign in to comment.