[processing] Fix constant raster cellsize - prefer cellsize over extent parameter #33771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so that rectangular pixels are avoided.
nyalldawson
approved these changes
Jan 14, 2020
|
@alexbruy can i get a second opinion here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes a fix of a bug in the Create constant raster layer algorithm which leads to rectangular (not square) pixels. The bug is caused because the input extent parameter is favored over the cellsize parameter.
This PR changes this behaviour and honors the input cellsize in order to achieve square pixels.
For reference, see old processing bugticket
This fix should possibly be backported.
Checklist
[x] Commit messages are descriptive and explain the rationale for changes
[x] Commits which fix bugs include
Fixes #11111at the bottom of the commit message[x] I have read the QGIS Coding Standards and this PR complies with them
[ ] New unit tests have been added for core changes
[x] I have run the
scripts/prepare-commit.shscript before each commit[ ] I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment