[ui][themes] Make attribute form constraints background coloring compatible with dark themes #55269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atible with dark themes
nirvn
added
GUI/UX
nyalldawson
approved these changes
Nov 13, 2023
|
@nirvn this probably caused an issue with normal theme's calendar widget when not null is enforced:
mind having a look? |
|
@elpaso , that's horrifying, I'll have a look at it. |
|
@nirvn have you had any chance to look at this? |
|
@nirvn, hi We too really need this problem to be resolved... |
|
(fixed here #59952) |
|
@nirvn Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before (left) vs. PR (right:
It's always preferable to use semi-opaque colors to taint a background instead of a fully opaque color, the latter is not flexible across various light/dark themes.