-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grass CRS fixes #58061
Merged
Merged
Grass CRS fixes #58061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key_Value* type cannot be cast to a number, and it's meaningless to do so anyway
Directly read the SRID and WKT, instead of trying to construct a projection from the raw properties. This allows lossless conversion of GRASS CRS to QGIS CRS, and eg avoids EPSG:3857 mapsets loading into QGIS as invalid projections
Use the more modern API so that the projection SRID and WKT are written losslessly to the mapset Avoids loss of projection information when creating mapsets
nyalldawson
added
GRASS
backport queued_ltr_backports
Queued Backports
backport release-3_38
labels
Jul 11, 2024
alexbruy
approved these changes
Jul 11, 2024
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-58061-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 391176c8209c491b1c83f192b5adba02a0b01731,40e97102e00ea4584b7c0b5dd661c2e183c83eae,88ffe42ad2b7cc0f062514d143d352be596485fb,79618bd92452b647565e6ac01936624049d535ec
# Push it to GitHub
git push --set-upstream origin backport-58061-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports Then, create a pull request where the |
qgis-bot
added
the
failed backport
The automated backport attempt failed, needs a manual backport
label
Jul 11, 2024
nyalldawson
added
backport queued_ltr_backports
Queued Backports
and removed
backport queued_ltr_backports
Queued Backports
failed backport
The automated backport attempt failed, needs a manual backport
labels
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #58049, and fix more situations where CRS information is lost when opening/creating GRASS mapsets