Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure QgsPropertyOverrideButtons always look correct #58103

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Ensure QgsPropertyOverrideButtons always look correct #58103

merged 2 commits into from
Jul 18, 2024

Conversation

nyalldawson
Copy link
Collaborator

We shouldn't require the main window stylesheet to be applied for these buttons to look right

@nyalldawson
Ensure QgsPropertyOverrideButtons always look correct
3da5b54 
We shouldn't require the main window stylesheet to be applied
for these buttons to look right
@github-actions github-actions bot added this to the 3.40.0 milestone Jul 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 7f21b33)

nirvn
nirvn approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes at the cost of not being able to customize the buttons via non-default themes, but IMHO that's an acceptable trade off here.

@nyalldawson
Copy link
Collaborator Author

@nirvn

This comes at the cost of not being able to customize the buttons via non-default themes, but IMHO that's an acceptable trade off here.

Ok, i've removed the non-functional styling from the themes

@nyalldawson nyalldawson merged commit ff63048 into qgis:master Jul 18, 2024
28 checks passed
@nyalldawson nyalldawson deleted the prop_override_stylesheet branch July 18, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirvn nirvn nirvn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nyalldawson @nirvn