Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use labeling engine to render linear referencing labels #58506

Merged
merged 7 commits into from
Sep 14, 2024

Conversation

nyalldawson
Copy link
Collaborator

(temporarily includes #58484)

This PR implements the missing API bits for allowing a feature renderer/symbol/symbol layer to interact with the labeling engine, and inject labels into the map. The end result is that labels formed from the linear referencing symbol layer will now participate in the map labeling problem, and eg cause other labels to shift placement to avoid overlaps.

(The same approach could be used in future to improve the point displacement label rendering)

Sponsored by the Swiss QGIS User Group

@github-actions github-actions bot added this to the 3.40.0 milestone Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 84f4aac)

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 12, 2024
This allows more efficient rendering when the document and metrics
have already been calculated
Where possible, we now use the labeling engine to register and
render labels from a linear referencing symbol layer. This ensures
that the linear referencing labels correctly participate in
the map labeling problem, including forcing other map labels
to be repositioned to avoid overlaps.
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 12, 2024
@qgis qgis deleted a comment from github-actions bot Sep 12, 2024
@qgis qgis deleted a comment from github-actions bot Sep 12, 2024
@nyalldawson nyalldawson added the Freeze Exempt Feature Freeze exemption granted label Sep 13, 2024
@qgis qgis deleted a comment from github-actions bot Sep 13, 2024
@nyalldawson nyalldawson merged commit 59d2308 into qgis:master Sep 14, 2024
30 checks passed
@nyalldawson nyalldawson deleted the symbol_label_bridge branch September 14, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Freeze Exempt Feature Freeze exemption granted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant